Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate and fix Optimal control tutorials from qutip-notebooks to qutip-tutorials #122

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Migrate and fix Optimal control tutorials from qutip-notebooks to qutip-tutorials #122

wants to merge 4 commits into from

Conversation

rochisha0
Copy link
Contributor

@rochisha0 rochisha0 commented Jan 17, 2025 •
edited
Loading

Migrate and update the Optimal Control tutorials from the qutip-notebooks repository to the qutip-tutorials repository. Ensure all tutorials are compatible with qutip-qtrl instead of the older qutip.control module. This involves revising code, validating outputs, and updating instructions to reflect changes functionality. It also removes the logging to make the tutorials more compact.

To do:

  1. Add the optimal-control overview
  2. Do the same for v5(?)

@ajgpitch
Copy link
Member

I checked the tutorials-v5/optimal-control/control-pulseoptim-Hadamard.ipynb and it imports qutip.control. This is not going work in v5. Needs to use qutip_qtrl.

@rochisha0
Copy link
Contributor Author

@ajgpitch I have fixed this and added overview. I think we should figure out, which order we want these notebooks to appear. I can name them in that particular order to show in the website index.

@ajgpitch
Copy link
Member

Definitely looking better now. Still focusing on the Hadamard example...

  1. I thought at some point we planned to move (copy) the Hadamard gate function into the main package. It would be nice not to have to depend on qutip_qip - can we check if this is done?
  2. It seems that this does not work with the current pip version of qutip-qtrl, do I need to install qutip_qtrl from Github?

@rochisha0
Copy link
Contributor Author

rochisha0 commented Jan 30, 2025 •
edited
Loading

I have removed the dependence on qutip_qip. It works for me using the current pip version of qutip_qtrl. @ajgpitch
Software Version
QuTiP 5.1.0.dev0+0b4260e
Numpy 1.26.4
SciPy 1.13.0
matplotlib 3.9.0
Number of CPUs 8
BLAS Info Generic
IPython 8.25.0
Python 3.12.3 | packaged by Anaconda, Inc. | (main, May 6 2024, 19:46:43) [GCC 11.2.0]
OS posix [linux]
Cython 3.0.10
Wed Jan 01 22:48:30 2025 IST

These are the versions I am using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rochisha0 @ajgpitch